Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIBULKED-538 “Are you sure" form notification banner wording for the case of bulk editing MARC fields for FOLIO Instances (follow up) #644

Merged
merged 3 commits into from
Nov 11, 2024

Conversation

vashjs
Copy link
Contributor

@vashjs vashjs commented Nov 8, 2024

After this PR merged new banner will be shown based on new status introduced by backend. Also preview of FOLIO items will be shown, in previous implementation it was just empty list.
Refs UIBULKED-538

image

This PR continues not completed work in #598

…case of bulk editing MARC fields for FOLIO Instances
Copy link

github-actions bot commented Nov 8, 2024

Jest Unit Test Statistics

    1 files  ±0    45 suites  ±0   3m 2s ⏱️ -5s
290 tests ±0  290 ✔️ ±0  0 💤 ±0  0 ±0 
297 runs  ±0  297 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 1d02c36. ± Comparison against base commit 835b064.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Nov 8, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 1d02c36. ± Comparison against base commit 835b064.

♻️ This comment has been updated with latest results.

Copy link

sonarqubecloud bot commented Nov 8, 2024

@vashjs vashjs requested a review from a team November 8, 2024 13:38
Copy link

@mariia-aloshyna mariia-aloshyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update CHANGELOG please

@vashjs vashjs changed the title UIBULKED-538 “Are you sure" form notification banner wording for the case of bulk editing MARC fields for FOLIO Instances UIBULKED-538 “Are you sure" form notification banner wording for the case of bulk editing MARC fields for FOLIO Instances (follow up) Nov 11, 2024
@vashjs
Copy link
Contributor Author

vashjs commented Nov 11, 2024

Update CHANGELOG please

Hi @mariia-aloshyna, Changelog already updated, this PR continues another one where changelog was updated. Added information in description. Thanks!

@vashjs vashjs requested a review from a team November 11, 2024 12:42
@vashjs vashjs merged commit 7b4adba into master Nov 11, 2024
6 checks passed
@vashjs vashjs deleted the UIBULKED-538-fix branch November 11, 2024 13:04
vashjs added a commit that referenced this pull request Nov 15, 2024
…case of bulk editing MARC fields for FOLIO Instances (follow up) (#644)

(cherry picked from commit 7b4adba)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants